----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67788/#review205586 -----------------------------------------------------------
Patch looks great! Reviews applied: [67788] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 29, 2018, 11:44 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67788/ > ----------------------------------------------------------- > > (Updated June 29, 2018, 11:44 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Kapil Arya. > > > Bugs: MESOS-9038 > https://issues.apache.org/jira/browse/MESOS-9038 > > > Repository: mesos > > > Description > ------- > > This modifies an existing test to account for archives with symlinks > under subdirectories. > > > Diffs > ----- > > 3rdparty/stout/tests/archiver_tests.cpp > cdf24a5d9accb1082e8bf3809c865a92d93e63d8 > > > Diff: https://reviews.apache.org/r/67788/diff/1/ > > > Testing > ------- > > ``` > make check > > # Revert the commit that fixed MESOS-9038. > git revert 22471b83a418e614b19a7ae50b73ee028dc7c363 --no-edit > cmake --build . --target stout-tests > > # Now this is expected to fail. > 3rdparty/stout/tests/stout-tests > --gtest_filter="*SYMLINK_ExtractTarGzFileWithLinks*" > ``` > > > Thanks, > > Joseph Wu > >
