----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67793/#review205606 -----------------------------------------------------------
Fix it, then Ship it! Looks like we never did follow through on distinguishing `libmesos_no_3rdparty_SOURCES` and `noinst_libmesos_no_3rdparty_HEADERS`. The form here certainly seems easier to modify, and we could always split out the headers explicitly without much work should we really want that. src/Makefile.am Lines 1369-1370 (patched) <https://reviews.apache.org/r/67793/#comment288465> At least in our "topological" include sort scheme these would come after `linux/systemd.hpp`. We seem to use the same scheme here. - Benjamin Bannier On June 30, 2018, 10:17 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67793/ > ----------------------------------------------------------- > > (Updated June 30, 2018, 10:17 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > The autotools build doesn't have a general style of separating > header and source files into separate build variables, so combine > both into the same `MESOS_LINUX_FILES` addition to make the style > more consistent. > > > Diffs > ----- > > src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21 > > > Diff: https://reviews.apache.org/r/67793/diff/1/ > > > Testing > ------- > > make check (Fedora 28) > > > Thanks, > > James Peach > >
