> On July 3, 2018, 2:28 a.m., Alexander Rojas wrote: > > src/master/master.cpp > > Lines 9667-9672 (patched) > > <https://reviews.apache.org/r/67722/diff/1/?file=2044750#file2044750line9674> > > > > Honestly, I'm not even sure there should be a warning there unless > > there is an error now that I think about it. > > > > If a framework is refused authentication because of invalid > > credentials, that is just normal behavior and should be logged as info.
I would make the error a warning to be consistent with what we do when authorizing an agent: https://github.com/apache/mesos/blob/bf69856f241590b652485e012580dbbdb5e11674/src/master/master.cpp#L6791-L6794 - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67722/#review205662 ----------------------------------------------------------- On July 3, 2018, 3:17 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67722/ > ----------------------------------------------------------- > > (Updated July 3, 2018, 3:17 a.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This patch fixes a bug where the code path could cause a crash because > of calling `Fture<T>::get()` on a future which is failed. > > > Diffs > ----- > > src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 > > > Diff: https://reviews.apache.org/r/67722/diff/2/ > > > Testing > ------- > > ```sh > make check > ``` > > > Thanks, > > Alexander Rojas > >
