----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67671/#review205812 -----------------------------------------------------------
Patch looks great! Reviews applied: [67671] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On July 6, 2018, 1:50 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67671/ > ----------------------------------------------------------- > > (Updated July 6, 2018, 1:50 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-8838 > https://issues.apache.org/jira/browse/MESOS-8838 > > > Repository: mesos > > > Description > ------- > > Since the agent uses e.g., a resource provider's name or type to > construct paths to persist resource provider state, changes to this > information on resource provider resubscription are not supported. > > This patch persists a resource provider's name and type in the > resource provider registry and rejects a resource provider > resubscription if incompatible changes are detected. Since we did not > persist this information previous to mesos-1.7.0 we cannot and do not > perform validation against resource provider registry information > stored with earlier versions of Mesos. > > > Diffs > ----- > > src/resource_provider/manager.cpp 6400e707ee834c73d4bf18c1f8d8344e8cf714cc > src/resource_provider/registrar.hpp > ded56e1c24a1f8b8db8dc70151682a7deb9e6544 > src/resource_provider/registrar.cpp > a855a2b61fdbfc96a12a133c702ecaf7af666d8b > src/resource_provider/registry.hpp 4c6c4d40686e3af8bbc7affbe3fa673479cc2fbf > src/resource_provider/registry.proto > 491263ef679cd4cea59338b002c6845d890f8eae > src/tests/resource_provider_manager_tests.cpp > 58bdbf0e88f59b5cb0cad42e38b24029fc0f2b41 > > > Diff: https://reviews.apache.org/r/67671/diff/2/ > > > Testing > ------- > > `sudo make check` > > > Thanks, > > Benjamin Bannier > >
