----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67776/#review205819 -----------------------------------------------------------
Ship it! I think that it would be nicer to wrap all the non-lazy initialization/cleanup in an `EnumCounter` class, but we can do that in separate patch. - Gastón Kleiman On July 6, 2018, 11:56 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67776/ > ----------------------------------------------------------- > > (Updated July 6, 2018, 11:56 a.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song. > > > Bugs: MESOS-8843 > https://issues.apache.org/jira/browse/MESOS-8843 > > > Repository: mesos > > > Description > ------- > > Added per-framework metrics for scheduler calls. > > > Diffs > ----- > > src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 > src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 > src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b > src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 > > > Diff: https://reviews.apache.org/r/67776/diff/3/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
