----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67147/#review205830 -----------------------------------------------------------
Ship it! Ship It! - Gastón Kleiman On July 3, 2018, 2:30 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67147/ > ----------------------------------------------------------- > > (Updated July 3, 2018, 2:30 p.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song. > > > Bugs: MESOS-8849 > https://issues.apache.org/jira/browse/MESOS-8849 > > > Repository: mesos > > > Description > ------- > > Included a missing header in the master metrics. > > > Diffs > ----- > > src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b > src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 > > > Diff: https://reviews.apache.org/r/67147/diff/2/ > > > Testing > ------- > > The subsequent patch in this chain exposes this missing header, since it > includes 'src/master/metrics.hpp' in the allocator metrics code, in a > compilation unit in which the scheduler header is not included. > > > Thanks, > > Greg Mann > >
