----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67853/#review205856 -----------------------------------------------------------
Ship it! Ship It! - Kevin Klues On July 9, 2018, 3:54 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67853/ > ----------------------------------------------------------- > > (Updated July 9, 2018, 3:54 p.m.) > > > Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff. > > > Bugs: MESOS-9058 > https://issues.apache.org/jira/browse/MESOS-9058 > > > Repository: mesos > > > Description > ------- > > With Python 3, virtualenv is built-in. We thus remove the error > messages if the script is run using Python 3 without virtualenv > installed on the machine. We also use `python` instead of > `virtualenv` to build the virtual environment. > > This change also fixes an issue on my computer where running > `build-virtualenv` with Python 3 displayed an error message: > `ModuleNotFoundError: No module named 'nodeenv'`. > > > Diffs > ----- > > support/build-virtualenv 5fda08187bb92847dba459550313edff756c9e7f > > > Diff: https://reviews.apache.org/r/67853/diff/4/ > > > Testing > ------- > > Ran `build-virtualenv` with python 2 and 3. > > > Thanks, > > Armand Grillet > >
