----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205883 -----------------------------------------------------------
Patch looks great! Reviews applied: [67693] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On July 6, 2018, 7:37 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67693/ > ----------------------------------------------------------- > > (Updated July 6, 2018, 7:37 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-8473 > https://issues.apache.org/jira/browse/MESOS-8473 > > > Repository: mesos > > > Description > ------- > > This patch adds filtering of operations reported for `GET_OPERATIONS` > calls. A principal is allowed to view see all operations for which it > is allowed to see the role of the underlying resources. > > > Diffs > ----- > > src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 > src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c > src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692 > > > Diff: https://reviews.apache.org/r/67693/diff/4/ > > > Testing > ------- > > `make check` > > The added tests fails without the corresponding changes to the master and > agent code. > > > Thanks, > > Benjamin Bannier > >
