----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67855/#review205916 -----------------------------------------------------------
Ship it! Can you clarify the commit message? It should probably mention something about always using `venv` for `python3` and `virtualenv` for `python2`. support/python3/mesos-style.py Lines 516 (patched) <https://reviews.apache.org/r/67855/#comment288846> Next time we make a modification here we should introduce a variable for the list of touched files `sys.argv[1:]`. - Benjamin Bannier On July 9, 2018, 12:35 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67855/ > ----------------------------------------------------------- > > (Updated July 9, 2018, 12:35 p.m.) > > > Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff. > > > Bugs: MESOS-8882 > https://issues.apache.org/jira/browse/MESOS-8882 > > > Repository: mesos > > > Description > ------- > > Added virtualenv requirements watcher to Python 3 mesos-style.py. > > > Diffs > ----- > > support/python3/mesos-style.py 0a4b1b1a0287011faf4488522f88587e07b3c874 > > > Diff: https://reviews.apache.org/r/67855/diff/1/ > > > Testing > ------- > > Checked that this commit trigerred the script (I am using Python 3 by > default). > > > Thanks, > > Armand Grillet > >
