----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67849/#review205946 -----------------------------------------------------------
src/Makefile.am Lines 1533 (patched) <https://reviews.apache.org/r/67849/#comment288870> Is there a reason to make `state.hpp` public? Is it because of some protoc problem? The `State` proto is supposed to be internal and only for SLRP or SERP to checkpoint volume states for now. src/Makefile.am Lines 1534 (patched) <https://reviews.apache.org/r/67849/#comment288871> Do we need to make this public? If we're just using the comparison and output operators, then it seems better to move them directly into `spec.hpp` and keep this file private. - Chun-Hung Hsiao On July 6, 2018, 8:50 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67849/ > ----------------------------------------------------------- > > (Updated July 6, 2018, 8:50 p.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Repository: mesos > > > Description > ------- > > Made some CSI-related utility headers public. > > > Diffs > ----- > > src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f > src/csi/state.hpp > src/csi/utils.hpp 5ce318e52bc39555ca09bf68dca6dedea988e5a4 > src/csi/utils.cpp fd6f95d88caf69e2ae197cf940beb93c164565bc > src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697 > src/resource_provider/storage/disk_profile_utils.hpp > 8a83a15ba555ce66bbb86b8df72178bce17a615a > src/resource_provider/storage/disk_profile_utils.cpp > 82c69d8b916a933f13e1185ffbf8ec65afd04ccf > src/resource_provider/storage/provider.cpp > b90a4b81838fec410a97a10ce44a811bb81c87eb > src/resource_provider/storage/uri_disk_profile_adaptor.hpp > 0484933b42d0bd66c689b06cb48f492eef7bc606 > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7 > src/tests/disk_profile_adaptor_tests.cpp > 4485f1635f484ce6e1c7c532eedb277f5eee118b > src/tests/storage_local_resource_provider_tests.cpp > 1afe8a8e0413ef225e952cd9cd6376e5d82774e5 > > > Diff: https://reviews.apache.org/r/67849/diff/1/ > > > Testing > ------- > > `make distcheck` > > > Thanks, > > Benjamin Bannier > >
