----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67882/#review206016 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/fd.hpp Lines 162-183 (original), 162-184 (patched) <https://reviews.apache.org/r/67882/#comment288978> Alternatively, these could be `get_socket()` etc. methods. - Andrew Schwartzmeyer On July 12, 2018, 12:10 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67882/ > ----------------------------------------------------------- > > (Updated July 12, 2018, 12:10 p.m.) > > > Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and Radhika > Jandhyala. > > > Repository: mesos > > > Description > ------- > > Windows: Made `int_fd` cast operators explicit. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp > fb5090448fd2d1a7f292648e57729fde7f20ad3d > 3rdparty/stout/include/stout/os/windows/close.hpp > 1dddae2f390521819c2f18cf98af67bd838f9686 > 3rdparty/stout/include/stout/os/windows/dup.hpp > 9dc2fa0f23b192de6f8d63876bef439055bf82ad > 3rdparty/stout/include/stout/os/windows/fcntl.hpp > 90cdbfbb519871e7b199c44a837c11994f656b6b > 3rdparty/stout/include/stout/os/windows/fd.hpp > 5c726fb2e2a6ca9be71941685a845ec2e9c5b721 > 3rdparty/stout/include/stout/os/windows/ftruncate.hpp > 27eadfd70e827f5449ddbfdabd13ef69b64ecc2b > 3rdparty/stout/include/stout/os/windows/lseek.hpp > c0ec71c8d21682207239b540ee216a9fcc0f7897 > 3rdparty/stout/include/stout/os/windows/read.hpp > 96d30e4caa1757272a955e78e5097d848664b676 > 3rdparty/stout/include/stout/os/windows/sendfile.hpp > 2c08bb7f32b7bcbf09a3f4f69f9753f73d0f7afb > 3rdparty/stout/include/stout/os/windows/shell.hpp > b9e06d667159d2fb5e266ce7f7e633deb1237a78 > 3rdparty/stout/include/stout/os/windows/socket.hpp > 4a8f52bfafd52888d1e7c4e37b867d006fa9c5b6 > 3rdparty/stout/include/stout/os/windows/stat.hpp > 62256094b9a58779e28dd78f1281a7d8bd7955d0 > 3rdparty/stout/include/stout/os/windows/write.hpp > 232218e5cb52fd28ea917b60c4289a221f3b5482 > 3rdparty/stout/tests/os/filesystem_tests.cpp > 09d0a40a74a293dcf6eecde2a443281e4b8d9fe8 > 3rdparty/stout/tests/os/sendfile_tests.cpp > cc1fa113eae5c2c68e2f4f21c35b700650db787c > 3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c > > > Diff: https://reviews.apache.org/r/67882/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
