----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67864/#review206049 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_validation_tests.cpp Line 1913 (original), 1852 (patched) <https://reviews.apache.org/r/67864/#comment289011> s/target/source/, s/MOUTN/MOUNT/ This should have resulted in a test failure, right? If not, the string in the returned error has to be fixed as well :) src/tests/master_validation_tests.cpp Line 1921 (original), 1860 (patched) <https://reviews.apache.org/r/67864/#comment289012> s/target/source/ - Jan Schlicht On July 12, 2018, 6:57 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67864/ > ----------------------------------------------------------- > > (Updated July 12, 2018, 6:57 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9066 > https://issues.apache.org/jira/browse/MESOS-9066 > > > Repository: mesos > > > Description > ------- > > Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations. > > > Diffs > ----- > > src/examples/test_csi_user_framework.cpp > 91212e990af711633f7b890b0c9e10587f9efe7c > src/tests/api_tests.cpp 728fb4c38c17c98b6c2a85447d3f32519c035e56 > src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb > src/tests/master_validation_tests.cpp > 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd > src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe > src/tests/operation_reconciliation_tests.cpp > d0bc73bfbf304833cebb76c538cb2c5552813838 > src/tests/persistent_volume_tests.cpp > 43f31b2e613666a989c205b8543ef1cde484d93c > src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6 > src/tests/resource_provider_manager_tests.cpp > cf15e5a1f26f0895865b53931298f61ce5cfccff > src/tests/storage_local_resource_provider_tests.cpp > 1afe8a8e0413ef225e952cd9cd6376e5d82774e5 > > > Diff: https://reviews.apache.org/r/67864/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
