----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67910/#review206072 -----------------------------------------------------------
Ship it! I've split this into 3 commits on my end and slightly changed some variable names in the commit that actually fixes the virtualenv management. Please see the commit logs for details. - Kevin Klues On July 13, 2018, 4:38 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67910/ > ----------------------------------------------------------- > > (Updated July 13, 2018, 4:38 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9075 > https://issues.apache.org/jira/browse/MESOS-9075 > > > Repository: mesos > > > Description > ------- > > The switch from Python 2 to Python 3 creates problems regarding the > virtual environment if a developer dangles between Python 2 and 3 as > we want the virtual environment to use the same version of Python as > the user to give useful logs when linting. > > This commit fixes the issue by adding a new check in the function of > `mesos-style.py` called `should_build_virtualenv` to see if the Python > interpreter version currently used is the one in the virtual > environement. If not, the virtual environment will get recreated. > > > Diffs > ----- > > support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 > support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 > > > Diff: https://reviews.apache.org/r/67910/diff/2/ > > > Testing > ------- > > Run the two `mesos-style.py` and `build-virtualenv` with > `MESOS_SUPPORT_PYTHON` set to 3 or not. Checked that the python intepreter > installed in the virtual environment was correct. > > > Thanks, > > Armand Grillet > >
