----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67892/#review206076 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On July 13, 2018, 6:39 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67892/ > ----------------------------------------------------------- > > (Updated July 13, 2018, 6:39 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9066 > https://issues.apache.org/jira/browse/MESOS-9066 > > > Repository: mesos > > > Description > ------- > > Since the disk types of the `CREATE_DISK` and `DESTROY_DISK` should have > been validated by the master, we now use `CHECK`s instead of returning > failures. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > b90a4b81838fec410a97a10ce44a811bb81c87eb > > > Diff: https://reviews.apache.org/r/67892/diff/2/ > > > Testing > ------- > > Tests done later in chain. > > > Thanks, > > Chun-Hung Hsiao > >
