----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67928/#review206114 -----------------------------------------------------------
Fix it, then Ship it! src/examples/balloon_framework.cpp Lines 304 (patched) <https://reviews.apache.org/r/67928/#comment289027> stati --> statistics? src/examples/balloon_framework.cpp Lines 309 (patched) <https://reviews.apache.org/r/67928/#comment289028> ditto src/examples/balloon_framework.cpp Line 304 (original), 316 (patched) <https://reviews.apache.org/r/67928/#comment289029> Let's add back the default. - Meng Zhu On July 16, 2018, 7:48 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67928/ > ----------------------------------------------------------- > > (Updated July 16, 2018, 7:48 a.m.) > > > Review request for mesos and Meng Zhu. > > > Repository: mesos > > > Description > ------- > > The framework currently exposes metric counters for various expected > and unexpected task termination reasons. Interpreting these counters > can be non-trivial since tasks might fail due to benign, but unknown > external reasons. > > This patch adds a counter for the tasks which actually made it to the > running stage which can be correlated with the different terminal task > counts. > > > Diffs > ----- > > src/examples/balloon_framework.cpp cbc25e45258b05a645363d4229c0a701baa5481c > > > Diff: https://reviews.apache.org/r/67928/diff/1/ > > > Testing > ------- > > Started the framework with a `local` master and examine the metric. > > > Thanks, > > Benjamin Bannier > >
