----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67867/#review206121 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Bannier On July 12, 2018, 7:09 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67867/ > ----------------------------------------------------------- > > (Updated July 12, 2018, 7:09 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, > Mesos Reviewbot, Till Toenshoff, and Zhitao Li. > > > Bugs: MESOS-9065 > https://issues.apache.org/jira/browse/MESOS-9065 > > > Repository: mesos > > > Description > ------- > > Apply the `override` keyword to libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/README.md 9846ecea45f742da74dd39d1701b5177d2f3f125 > 3rdparty/libprocess/examples/example.cpp > 0db2d03bccb7b4910acfd7e08248f022bc74b6ef > 3rdparty/libprocess/include/process/async.hpp > 116c90c01655cd1df67616d9c927f6769f5c92da > 3rdparty/libprocess/include/process/collect.hpp > 5263f0134808a0161b16b3b45871f711b0f5cb45 > 3rdparty/libprocess/include/process/event.hpp > ec64eb786b6cf30bf03ba07a30c6e44d2db9173a > 3rdparty/libprocess/include/process/filter.hpp > 3f4a8272c451e333ebf9ff79c5f0fee329a8450a > 3rdparty/libprocess/include/process/firewall.hpp > 0a7b985380893820d0193f7b2eb657ee8c07430e > 3rdparty/libprocess/include/process/gmock.hpp > b5ead1c2ecacdb468a319c98edd2ffc831a9f74c > 3rdparty/libprocess/include/process/grpc.hpp > 0ff8184791277ed02b30481b352be60f10743428 > 3rdparty/libprocess/include/process/gtest.hpp > 79ea2b1f6a2a16ff9c5aae281c900e50940877bf > 3rdparty/libprocess/include/process/help.hpp > 3393b71c484bb8c55c6a4cd2a27dcb798e841a80 > 3rdparty/libprocess/include/process/limiter.hpp > b4b6a7bb48aa19fa40c0ea9f8759b8f553f43ca6 > 3rdparty/libprocess/include/process/logging.hpp > aad7ce8caa193e6aff1a295fef899b49fcfce7b0 > 3rdparty/libprocess/include/process/metrics/counter.hpp > 15aeeb5710636d4e11b862faee50fd6ea4d1cb07 > 3rdparty/libprocess/include/process/metrics/metrics.hpp > f9b72029b2c85826c91b1d7656b0af94dc87010c > 3rdparty/libprocess/include/process/metrics/pull_gauge.hpp > 5c2a227425f31c439bd48b58171d4038a7f04e5f > 3rdparty/libprocess/include/process/metrics/push_gauge.hpp > 5c39846172fc46c3022e9aa420460f5b0fb6db2e > 3rdparty/libprocess/include/process/metrics/timer.hpp > 0a9c0227c457c6c81a59f65f901a5464ee00983d > 3rdparty/libprocess/include/process/process.hpp > c36df991b6a2c120ab0562e8ff907f9fbf8630d1 > 3rdparty/libprocess/include/process/profiler.hpp > 74890ae7b10c15b77ef1d112a7ebfb3a45b29ed2 > 3rdparty/libprocess/include/process/protobuf.hpp > 5a75a83d294e2d14f81503b113724893c0e140f3 > 3rdparty/libprocess/include/process/reap.hpp > 628bc0a6ec59bfe6bfa7c54906ea266ac31a71a7 > 3rdparty/libprocess/include/process/run.hpp > 0d282c989b8ddeb9ddb31a050cd52afe01623a66 > 3rdparty/libprocess/include/process/sequence.hpp > 24712b16953347eb05a28ad50fbdfad17bf64f19 > 3rdparty/libprocess/include/process/system.hpp > 81ded8af1015fe3ecd578ed98759b66f917ee264 > 3rdparty/libprocess/src/encoder.hpp > 70b5ec479e90c0eb6ac729b465739b581729a956 > 3rdparty/libprocess/src/http.cpp dc38716960da98b861ee69ae310068e2db1245bb > 3rdparty/libprocess/src/http_proxy.hpp > 5b6e7e8786ed9eab50cd4c2cfdec455c92d72eca > 3rdparty/libprocess/src/memory_profiler.hpp > 617f8de27949f2e536e53c122d7269f2a919814b > 3rdparty/libprocess/src/poll_socket.hpp > eebd7182e433adabf6bb20c41d6ecf1863adf992 > 3rdparty/libprocess/src/process.cpp > b3bd0286e09dcb9d0867679c6a509c34e309a72e > 3rdparty/libprocess/src/tests/benchmarks.cpp > 604122a2f33d7abfab92631d9eac33b6753e846b > 3rdparty/libprocess/src/tests/http_tests.cpp > 5429034e9f4a1a6a4c4dc53a9f7e01dca119ea24 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > a5b41ed3f4491244656222681f443e7ed55393c2 > 3rdparty/libprocess/src/tests/process_tests.cpp > 2f8a8234aa1cb6128a85254efc81868c19e6fdac > 3rdparty/libprocess/src/tests/profiler_tests.cpp > 995bd02f6ecce484cd9b2aca355c2707d73d40b2 > > > Diff: https://reviews.apache.org/r/67867/diff/3/ > > > Testing > ------- > > make check (Fedora 28) > > The compliation database was generated using the method in > `support/mesos-tidy/entrypoint.sh`. I also used `-DENABLE_GRPC=YES`, > `-DENABLE_JEMALLOC_ALLOCATOR` and `-DENABLE_JAVA`. I wasn't able to get the > SSL support to build on F28, and not sure how the Python support works in > cmake. > > > Thanks, > > James Peach > >
