----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67869/#review206133 -----------------------------------------------------------
Ship it! As mentioned in my reply to Ben, I am _for_ this change, as I believe that if we care about it, we need to call it out in addition to its presence in the Google Style Guide (that thing is enormous!). - Andrew Schwartzmeyer On July 11, 2018, 10:03 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67869/ > ----------------------------------------------------------- > > (Updated July 11, 2018, 10:03 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, > Mesos Reviewbot, Till Toenshoff, and Zhitao Li. > > > Bugs: MESOS-9065 > https://issues.apache.org/jira/browse/MESOS-9065 > > > Repository: mesos > > > Description > ------- > > Add an explicit guideline to the Mesos C++ style guide that the use of > `override` keyword is required. Update cpplint and clang-tidy tooling > to encourage this. > > > Diffs > ----- > > docs/c++-style-guide.md 80a1af318984d47bdfa641aa12e28963d3183fea > support/clang-tidy fcffb39089573a708dc3f2052f639a1a3621040d > support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 > > > Diff: https://reviews.apache.org/r/67869/diff/2/ > > > Testing > ------- > > Manual. The `cpplint` change doesn't appear to enforce the use of `override`. > > > Thanks, > > James Peach > >
