> On July 16, 2018, 1:32 p.m., Andrew Schwartzmeyer wrote: > > Did you have an automated way of finding where we should apply `override` > > in existing code? I'd like to see if there's any Windows-only code/tests we > > should fix too. > > Armand Grillet wrote: > What do you mean by `override`? I have applied `2to3` on the CLI codebase > to find what needed to be updated. I haven't run `mesos-cli-tests` on a > Windows machine, that should tell us if we need to fix something else for > that operating system.
Wrong review... I think I was copy-pasting and had a couple tabs open. Sorry! - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review206125 ----------------------------------------------------------- On July 6, 2018, 6:56 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67488/ > ----------------------------------------------------------- > > (Updated July 6, 2018, 6:56 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, > and Kevin Klues. > > > Bugs: MESOS-8955 > https://issues.apache.org/jira/browse/MESOS-8955 > > > Repository: mesos > > > Description > ------- > > The build tools are also up to date thus the CLI can still be built > using Autotools and CMake. No features have been added to the CLI. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 > configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b > src/Makefile.am db42e71d90ff2066e104f4b9c269c5e78a9a6ada > src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca > src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 > src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c > src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f > src/python/cli_new/lib/cli/config.py > 6f92622725d8a042a2a728fd38c977ac690ef6be > src/python/cli_new/lib/cli/docopt.py > 86a4e9c74326fb80cc59487113f07358dd96960d > src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b > src/python/cli_new/lib/cli/plugins/agent/main.py > 59280ece8ebd00bb96df3675b6356a26cc48a2c0 > src/python/cli_new/lib/cli/plugins/task/main.py > cc6cff56c71262729a8870017bef2e97636abe5a > src/python/cli_new/lib/cli/tests/base.py > 89360e6cac5ca910044a5a82fab7237510edee7f > src/python/cli_new/lib/cli/tests/tests.py > 79e1036f6d11c63884091fe43672607b03955c1a > src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 > src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 > src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 > src/python/lib/tox.ini 05b633e837fa39a36fb2c5a0778513ce743099db > support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 > support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 > > > Diff: https://reviews.apache.org/r/67488/diff/12/ > > > Testing > ------- > > Testing done on Fedora 25 with `python` being Python 2.7, `python3` being > Python 3.5 and `python36` being Python 3.6. > > > For Autotools: > > ``` > $ ./bootstrap > $ mkdir build > $ cd build > $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java > $ make check > ``` > > For CMake: > > ``` > $ ./bootstrap > $ mkdir build > $ cd build > $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36 > $ cmake --build . -- -j16 > $ ./src/mesos > Mesos CLI > > Usage: > mesos (-h | --help) > mesos --version > mesos <command> [<args>...] > > Options: > -h --help Show this screen. > --version Show version info. > > Commands: > agent Interacts with the Mesos agents > config Interacts with the Mesos CLI configuration file > task Interacts with the tasks running in a Mesos cluster > > See 'mesos help <command>' for more information on a specific command. > $ cmake --build . --target tests -- -j16 > $ ctest -R CLI > Test project /home/agrillet/apache-mesos/build > Start 4: CLITests > 1/1 Test #4: CLITests ......................... Passed 3.63 sec > > 100% tests passed, 0 tests failed out of 1 > ``` > > Checked that the the CLI tests were run, that the content of the directory > build/src/cli was as expected, and that build/src/mesos was correctly running. > > > Thanks, > > Armand Grillet > >
