----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67947/#review206168 -----------------------------------------------------------
Ship it! Nice! Note that if we always wanted compilable commits, we could commit r/67938 with a default argument, then add explicit arguments for all users in this patch, and finally remove the default argument in a cleanup. That sounds like the overkill it is :D - Benjamin Bannier On July 17, 2018, 10:21 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67947/ > ----------------------------------------------------------- > > (Updated July 17, 2018, 10:21 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-9055 > https://issues.apache.org/jira/browse/MESOS-9055 > > > Repository: mesos > > > Description > ------- > > Passed the default options when making gRPC calls. > > > Diffs > ----- > > src/csi/client.cpp a36e6228f39405f729e347db51ccd95c5fb76cdb > > > Diff: https://reviews.apache.org/r/67947/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
