----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67953/#review206184 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On July 17, 2018, 5:05 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67953/ > ----------------------------------------------------------- > > (Updated July 17, 2018, 5:05 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and > Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Clang can emit a `-Winconsistent-missing-override` warning for most > uses of the Google Mock `MOCK_METHOD` family of macros. See also > https://github.com/google/googletest/issues/533. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 49b2dc0deec939e4c61b39c91bc5be4765fee194 > configure.ac 5f64168ce8867b23f0aed20f30682ebd35711ceb > > > Diff: https://reviews.apache.org/r/67953/diff/1/ > > > Testing > ------- > > make (Fedora 28) > > > Thanks, > > James Peach > >
