----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67968/#review206220 -----------------------------------------------------------
PASS: Mesos patch 67968 was successfully built and tested. Reviews applied: `['67968']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1955/mesos-review-67968 - Mesos Reviewbot Windows On July 18, 2018, 8:48 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67968/ > ----------------------------------------------------------- > > (Updated July 18, 2018, 8:48 p.m.) > > > Review request for mesos and Gilbert Song. > > > Repository: mesos > > > Description > ------- > > While we currently log when we start destroying a container or > provisioned volumes, we do not log when the destroy is done. This > makes it hard to understand how dependent destroy operations, e.g., > involving nested containers, could interact. > > This patch adds logging when a mesos or docker containerizer, or > provisioner destroy path ends. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5 > src/slave/containerizer/mesos/containerizer.cpp > 98129d006cda9b65804b518619b6addc8990410a > src/slave/containerizer/mesos/provisioner/provisioner.cpp > ac402fbead81e4b356cb35cea08a00049002e870 > > > Diff: https://reviews.apache.org/r/67968/diff/1/ > > > Testing > ------- > > Since this patch just adds logging, it is almost a non-functional change. Ran > `make check` anyway. > > > Thanks, > > Benjamin Bannier > >
