-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67993/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Benno Evers.
Repository: mesos
Description
-------
The state serving code was constructing `Resources` wrappers in
order to jsonify resources. This incurs a copy of the underlying
Resource objects which is unnecessary and can be costly. This
removes the copy by proving a direct way to jsonify
`RepeatedPtrField<Resource>`.
This shows a small 10-15% reduction in the master StateQuery
benchmark timings:
min q1 q3 max
baseline 3.48 3.54 4.12 4.40
after this patch 2.82 3.11 3.31 3.71
Diffs
-----
src/common/http.hpp 9d2b01f5cb0f787d1ea84d298b25b7e0d072cc66
src/common/http.cpp 9dfbfd12e22b215a24d0598b5c87d96807dc7a6c
src/master/http.cpp c855de1b7bb71cb455d111fcd71c4486f421f2c2
src/slave/http.cpp cf93c487b0936baf70238ffe6eba62f752ea9a81
Diff: https://reviews.apache.org/r/67993/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
