----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67992/#review206274 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp Line 724 (original), 720 (patched) <https://reviews.apache.org/r/67992/#comment289177> Let's not use C-style casts. 3rdparty/libprocess/src/http.cpp Lines 729 (patched) <https://reviews.apache.org/r/67992/#comment289178> Ditto. - Benno Evers On July 20, 2018, 3:39 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67992/ > ----------------------------------------------------------- > > (Updated July 20, 2018, 3:39 a.m.) > > > Review request for mesos, Alexander Rukletsov and Benno Evers. > > > Repository: mesos > > > Description > ------- > > In the common case where no jsonp is passed this avoids an extra copy > out from the ostringstream. In the jsonp case, the performance should > be near identical or better as we now pre-reserve the space needed > for the body. > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp cbb910282a4aff8a914dbd13ff20fc70d929c269 > > > Diff: https://reviews.apache.org/r/67992/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
