> On July 20, 2018, 10:46 a.m., Benno Evers wrote: > > It seems unfortunate that we have to break the API for this. Maybe it would > > be possible to have an empty `std::string` member in `StringWriter` that > > can serve as a buffer and would be written in the destructor, so we can > > emulate `append()`?
There wasn't a use case for append, but thinking over this again, it does seem valuable from a performance perspective to not have to force callers to build up a string before calling `set()`. I'll see if rapidjson supports the append use case and if so add it back. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67991/#review206273 ----------------------------------------------------------- On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67991/ > ----------------------------------------------------------- > > (Updated July 20, 2018, 3:38 a.m.) > > > Review request for mesos, Alexander Rukletsov and Benno Evers. > > > Bugs: MESOS-9092 > https://issues.apache.org/jira/browse/MESOS-9092 > > > Repository: mesos > > > Description > ------- > > The `StringWriter` no longer allows appending multiple times > and instead has a `set` function that must be used. > > > Diffs > ----- > > src/common/http.cpp 9dfbfd12e22b215a24d0598b5c87d96807dc7a6c > src/master/http.cpp c855de1b7bb71cb455d111fcd71c4486f421f2c2 > src/slave/http.cpp cf93c487b0936baf70238ffe6eba62f752ea9a81 > > > Diff: https://reviews.apache.org/r/67991/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
