----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67978/#review206356 -----------------------------------------------------------
Ship it! Ship It! - John Kordich On July 19, 2018, 8:44 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67978/ > ----------------------------------------------------------- > > (Updated July 19, 2018, 8:44 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > Liangyu Zhao, and Radhika Jandhyala. > > > Bugs: MESOS-5941 > https://issues.apache.org/jira/browse/MESOS-5941 > > > Repository: mesos > > > Description > ------- > > This resolves MESOS-5941. Note that on Windows, `os::killtree()` is > only valid for processes specifically spawned in a group via a job > object, otherwise it will fail (and the failure is not being checked > here). Since the `linkee` process only ever spawns the single OS > process `test-linkee`, it is safe to switch to `os::kill()` which can > correctly kill it. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/process_tests.cpp > 8baf60d8bbb675e26fea5e76c825ef73fedbc629 > > > Diff: https://reviews.apache.org/r/67978/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
