----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67998/#review206374 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rukletsov On July 20, 2018, 10:08 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67998/ > ----------------------------------------------------------- > > (Updated July 20, 2018, 10:08 a.m.) > > > Review request for mesos, Alexander Rukletsov and Andrew Schwartzmeyer. > > > Repository: mesos > > > Description > ------- > > This patch performs some cleanups: > > * do not emit `realpath` errors when validating filename-like strings > in the cmake build, > * prevent stray output of log headings when no issues were found, > * emit all diagnostics to stderr, > * return with an error code if issues were found. > > > Diffs > ----- > > support/check-cmake-missing-files.sh > b17e8715eb0ceb0c82d87372e2b756741ad6a7e9 > > > Diff: https://reviews.apache.org/r/67998/diff/1/ > > > Testing > ------- > > Checked output before and after https://reviews.apache.org/r/67751/. > > > Thanks, > > Benjamin Bannier > >
