----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67988/#review206407 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/jsonify.hpp Lines 123 (patched) <https://reviews.apache.org/r/67988/#comment289347> Can you please remove the trailing underscore then? It is weird to see it in a public symbol. 3rdparty/stout/include/stout/jsonify.hpp Lines 366-368 (original), 273-275 (patched) <https://reviews.apache.org/r/67988/#comment289345> Do we still want / need a `CHECK` then? 3rdparty/stout/include/stout/jsonify.hpp Line 375 (original), 282-284 (patched) <https://reviews.apache.org/r/67988/#comment289346> ditto - Alexander Rukletsov On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67988/ > ----------------------------------------------------------- > > (Updated July 20, 2018, 3:38 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benno Evers, and Michael Park. > > > Bugs: MESOS-9092 > https://issues.apache.org/jira/browse/MESOS-9092 > > > Repository: mesos > > > Description > ------- > > This reduces the time needed for the client to finish receiving a > master's /state response by 50% in the `StateQuery` benchmark: > > min q1 q3 max > baseline 6.52 6.76 7.33 8.26 > rapidjson w/ SIMD 3.48 3.54 4.12 4.4 > rapidjson 3.29 3.32 3.65 3.85 > > SIMD is left disabled for now since it showed slightly slower > results. > > > Diffs > ----- > > 3rdparty/stout/include/stout/jsonify.hpp > 2314980e185ee61cc2ea54f1b4d2a8b35e58121c > > > Diff: https://reviews.apache.org/r/67988/diff/2/ > > > Testing > ------- > > Tested at the end of this chain, since this is split across > stout/libprocess/mesos. > > > Thanks, > > Benjamin Mahler > >
