> On July 24, 2018, 5:41 p.m., Alexander Rukletsov wrote: > > 3rdparty/Makefile.am > > Lines 327 (patched) > > <https://reviews.apache.org/r/67987/diff/3/?file=2063102#file2063102line327> > > > > s/radidjson/rapidjson/ > > > > Also, I don't see you using `rapidjsondir`, can you please explain me > > why you declare it?
It's how automake works, the key quote from the manual is: > A given prefix (e.g. `zar`) is valid if a variable of the same name with > `dir` appended is defined (e.g. `zardir`). - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67987/#review206400 ----------------------------------------------------------- On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67987/ > ----------------------------------------------------------- > > (Updated July 20, 2018, 3:38 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benno Evers, and James Peach. > > > Bugs: MESOS-9092 > https://issues.apache.org/jira/browse/MESOS-9092 > > > Repository: mesos > > > Description > ------- > > This includes a stripped bundle of the latest release. Stripping > is required for licensing (see rapidjson.md), but also helps reduce > the bloat in the mesos git repo. > > Also included is a readme for how to update the dependency. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f > 3rdparty/Makefile.am 6123b8a0164d50f0bd771d2e5f485379811e7fcb > 3rdparty/README.md fa9a6483ca2dc4980767a2cb723d654e342e6bb8 > 3rdparty/cmake/Versions.cmake 0a897d808cd9e05ac0d1a4e1ca61b8f3538f0c4a > 3rdparty/rapidjson-1.1.0.tar.gz PRE-CREATION > 3rdparty/rapidjson.md PRE-CREATION > 3rdparty/versions.am 57792800c4b4b67dd55a316ce00480db6c253d34 > configure.ac e86c496140ee9732ad3204ef22ae8ce60cd5c079 > src/Makefile.am ecb95ef152fd37e5e83c4f6415489f4cf3959578 > > > Diff: https://reviews.apache.org/r/67987/diff/3/ > > > Testing > ------- > > Tested at the end of this chain, since this is split across > stout/libprocess/mesos. > > > Thanks, > > Benjamin Mahler > >
