----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67877/#review206458 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/tests/benchmarks.cpp Lines 695-703 (patched) <https://reviews.apache.org/r/67877/#comment289422> Nit: two newlines before/after the test case instantiation? 3rdparty/libprocess/src/tests/benchmarks.cpp Lines 704 (patched) <https://reviews.apache.org/r/67877/#comment289423> s/are/is/ 3rdparty/libprocess/src/tests/benchmarks.cpp Lines 707 (patched) <https://reviews.apache.org/r/67877/#comment289424> Nit: seems like we use a mix of snake case and camel case in this file, but camel case is a bit more common? I'm fine either way here, but wanted to bring it up. - Greg Mann On July 11, 2018, 10:51 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67877/ > ----------------------------------------------------------- > > (Updated July 11, 2018, 10:51 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-9068 > https://issues.apache.org/jira/browse/MESOS-9068 > > > Repository: mesos > > > Description > ------- > > This initial benchmark focuses on adding a large number of counters > and measuring how long the add/remove and snapshot takes. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/benchmarks.cpp > 604122a2f33d7abfab92631d9eac33b6753e846b > > > Diff: https://reviews.apache.org/r/67877/diff/3/ > > > Testing > ------- > > Before https://reviews.apache.org/r/67871/: > > ``` > [==========] Running 5 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 5 tests from MetricsCount/Metrics_BENCHMARK_Test > [ RUN ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/0 > Added 1 counters in 168443ns > Snapshot of 1 counters in 339047ns > HTTP /snapshot of 1 counters in 1.999797ms > Removed 1 counters in 94595ns > [ OK ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/0 (3 ms) > [ RUN ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/1 > Added 100 counters in 3.542703ms > Snapshot of 100 counters in 1.119107ms > HTTP /snapshot of 100 counters in 500.982997ms > Removed 100 counters in 3.949413ms > [ OK ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/1 (510 ms) > [ RUN ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/2 > Added 1000 counters in 27.697086ms > Snapshot of 1000 counters in 9.232065ms > HTTP /snapshot of 1000 counters in 473.66825ms > Removed 1000 counters in 31.632763ms > [ OK ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/2 (544 ms) > [ RUN ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/3 > Added 10000 counters in 277.567781ms > Snapshot of 10000 counters in 81.45371ms > HTTP /snapshot of 10000 counters in 219.1157ms > Removed 10000 counters in 309.334783ms > [ OK ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/3 (902 ms) > [ RUN ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/4 > Added 100000 counters in 3.753352484secs > Snapshot of 100000 counters in 1.033072727secs > HTTP /snapshot of 100000 counters in 2.226777961secs > Removed 100000 counters in 4.851697589secs > [ OK ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/4 (11996 ms) > [----------] 5 tests from MetricsCount/Metrics_BENCHMARK_Test (13955 ms total) > > [----------] Global test environment tear-down > [==========] 5 tests from 1 test case ran. (13955 ms total) > [ PASSED ] 5 tests. > ``` > > After https://reviews.apache.org/r/67871/: > > ``` > [==========] Running 5 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 5 tests from MetricsCount/Metrics_BENCHMARK_Test > [ RUN ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/0 > Added 1 counters in 102994ns > Snapshot of 1 counters in 266999ns > HTTP /snapshot of 1 counters in 1.83628ms > Removed 1 counters in 27402ns > [ OK ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/0 (2 ms) > [ RUN ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/1 > Added 100 counters in 3.049965ms > Snapshot of 100 counters in 930319ns > HTTP /snapshot of 100 counters in 501.558737ms > Removed 100 counters in 4.996015ms > [ OK ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/1 (511 ms) > [ RUN ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/2 > Added 1000 counters in 28.623101ms > Snapshot of 1000 counters in 7.496592ms > HTTP /snapshot of 1000 counters in 470.870567ms > Removed 1000 counters in 39.663126ms > [ OK ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/2 (548 ms) > [ RUN ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/3 > Added 10000 counters in 335.506147ms > Snapshot of 10000 counters in 67.963256ms > HTTP /snapshot of 10000 counters in 154.661098ms > Removed 10000 counters in 333.06148ms > [ OK ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/3 (904 ms) > [ RUN ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/4 > Added 100000 counters in 3.396691566secs > Snapshot of 100000 counters in 640.134635ms > HTTP /snapshot of 100000 counters in 1.404702464secs > Removed 100000 counters in 3.526395358secs > [ OK ] MetricsCount/Metrics_BENCHMARK_Test.Scalability/4 (9119 ms) > [----------] 5 tests from MetricsCount/Metrics_BENCHMARK_Test (11084 ms total) > > [----------] Global test environment tear-down > [==========] 5 tests from 1 test case ran. (11084 ms total) > [ PASSED ] 5 tests. > ``` > > > Thanks, > > Benjamin Mahler > >
