----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67878/#review206460 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_tests.cpp Lines 6109 (patched) <https://reviews.apache.org/r/67878/#comment289433> Ditto using a single metrics object per test. We should also test that the value of this metrics is 0 before launching the task. src/tests/scheduler_tests.cpp Lines 1599 (patched) <https://reviews.apache.org/r/67878/#comment289430> Nit: `JSON::Object` is mutable, so we could use a single `JSON::Object` and name it `metrics` instead of `metrics1`. - Gastón Kleiman On July 25, 2018, 8:36 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67878/ > ----------------------------------------------------------- > > (Updated July 25, 2018, 8:36 a.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song. > > > Repository: mesos > > > Description > ------- > > Updated tests to check per-framework metrics. > > > Diffs > ----- > > src/tests/master_tests.cpp 44b0ac39f87c6415e130c5e7f505428642739311 > src/tests/scheduler_tests.cpp bcdd0ec010889b4155a0feebe0248b7593d8bf0c > > > Diff: https://reviews.apache.org/r/67878/diff/5/ > > > Testing > ------- > > `make check` > > Also ran in internal CI pipeline, tests were green on all platforms. > > > Thanks, > > Greg Mann > >
