> On July 25, 2018, 11:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 287 (original), 288 (patched) > > <https://reviews.apache.org/r/66870/diff/6/?file=2063434#file2063434line288> > > > > It jumps out to the reader as a potential bug that the activate case > > doesn't have a `reviveRole` call to make it symmetric. Shall we just add > > one? Is this activate call a no-op?
This relies on the gauge being initialized to zero when the framework is added, but I agree that it's better to call `reviveRole` explicitly; I'll add it. Thx! - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66870/#review206482 ----------------------------------------------------------- On July 24, 2018, 3:40 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66870/ > ----------------------------------------------------------- > > (Updated July 24, 2018, 3:40 p.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added per-framework metrics for suppressed roles. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 707dd6bd0f255a64d759ce87cbf75be57d86b392 > src/master/allocator/mesos/metrics.hpp > 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b > src/master/allocator/mesos/metrics.cpp > 82990b2dc0b827a43a392d898667eaf58c77ea36 > > > Diff: https://reviews.apache.org/r/66870/diff/6/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
