-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67916/
-----------------------------------------------------------
(Updated July 30, 2018, 11:02 a.m.)
Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
Changes
-------
Does not fix MESOS-8990 (yet).
Bugs: MESOS-8990
https://issues.apache.org/jira/browse/MESOS-8990
Repository: mesos
Description
-------
Per MESOS-8990, our Google Test dependency needs a patch from
upstream, https://github.com/google/googletest/pull/1620, in order to
continue building with the next version of MSVC (and potentially other
compilers).
This patch file was generated by cherry-picking `f66ab00` from
`master` onto `release-1.8.0` in the Google Test repo, and resolving
the merge conflict.
Diffs
-----
3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f
3rdparty/googletest-release-1.8.0.patch PRE-CREATION
Diff: https://reviews.apache.org/r/67916/diff/1/
Testing (updated)
-------
Repro'ed MESOS-8990 on Windows with Visual Studio Preview, and the following
(temporary) CMake changes:
```
# Set the default standard to C++11 for all targets.
-set(CMAKE_CXX_STANDARD 11)
-set(CMAKE_CXX_STANDARD_REQUIRED ON)
+# set(CMAKE_CXX_STANDARD 11)
+# set(CMAKE_CXX_STANDARD_REQUIRED ON)
# Do not use, for example, `-std=gnu++11`.
-set(CMAKE_CXX_EXTENSIONS OFF)
+# set(CMAKE_CXX_EXTENSIONS OFF)
+add_compile_options(/std:c++latest)
+add_definitions(-D_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING)
+add_definitions(-D_HAS_AUTO_PTR_ETC=1)
+add_definitions(-D_HAS_TR1_NAMESPACE=1)
+add_definitions(-D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING)
+add_definitions(-D_SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING)
```
Unfortunately, it still repro'ed with this patch applied too, so I need to
figure out what we missed.
Thanks,
Andrew Schwartzmeyer
