----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67930/#review206624 -----------------------------------------------------------
Fix it, then Ship it! src/tests/uri_fetcher_tests.cpp Lines 281-283 (patched) <https://reviews.apache.org/r/67930/#comment289667> nit: `static constexpr char DOCKER_IMAGE[]` (like above) - Andrew Schwartzmeyer On July 18, 2018, 2:27 a.m., Liangyu Zhao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67930/ > ----------------------------------------------------------- > > (Updated July 18, 2018, 2:27 a.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Enabled Internet test environment on Windows. Disabled Internet > HealthCheckTests on Windows, since they require complete development. > Modified DockerFetcherPluginTest to fetch `microsoft/nanoserver` for > more extensive test for fetcher on Windows. > > > Diffs > ----- > > src/tests/environment.cpp 3b84c0a413193badbbdb6d3ee71d74f3ab85c90b > src/tests/health_check_tests.cpp 34102e2e3ff90c194bea83ae8a702181121d6522 > src/tests/uri_fetcher_tests.cpp 816d8ec2503ea79d069c062dfa2f01224b263bf6 > > > Diff: https://reviews.apache.org/r/67930/diff/3/ > > > Testing > ------- > > > Thanks, > > Liangyu Zhao > >
