----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68103/#review206631 -----------------------------------------------------------
include/mesos/authorizer/acls.proto Lines 561 (patched) <https://reviews.apache.org/r/68103/#comment289682> Let's use a sigular term for consistency: `ViewResourceProvider`. include/mesos/authorizer/acls.proto Lines 652 (patched) <https://reviews.apache.org/r/68103/#comment289683> `repeated ACL.ViewResourceProvider view_resource_providers` include/mesos/authorizer/authorizer.proto Lines 275 (patched) <https://reviews.apache.org/r/68103/#comment289684> `VIEW_RESOURCE_PROVIDER` src/authorizer/local/authorizer.cpp Lines 419-422 (patched) <https://reviews.apache.org/r/68103/#comment289685> How about merging this into the above? src/authorizer/local/authorizer.cpp Lines 1772 (patched) <https://reviews.apache.org/r/68103/#comment289686> s/`PruneImages`/`ViewResourceProvider`/ src/tests/authorization_tests.cpp Lines 4715 (patched) <https://reviews.apache.org/r/68103/#comment289687> s/`ViewResourceProviders`/`ViewResourceProvider`/ src/tests/authorization_tests.cpp Lines 4721 (patched) <https://reviews.apache.org/r/68103/#comment289692> ``` // ... can view resource provider information. ``` src/tests/authorization_tests.cpp Lines 4728 (patched) <https://reviews.apache.org/r/68103/#comment289693> Ditto. src/tests/authorization_tests.cpp Lines 4754 (patched) <https://reviews.apache.org/r/68103/#comment289694> ``` // ... with invalid ACLs. ``` - Chun-Hung Hsiao On July 30, 2018, 8:57 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68103/ > ----------------------------------------------------------- > > (Updated July 30, 2018, 8:57 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-8314 > https://issues.apache.org/jira/browse/MESOS-8314 > > > Repository: mesos > > > Description > ------- > > Added an authorizer action for viewing of resource provider information. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > 1777c04316bfd7493894f0e782f170fe8437aafe > include/mesos/authorizer/authorizer.proto > 8b5fa09f389ca4c26f8390d35af32c4cdd561418 > src/authorizer/local/authorizer.cpp > abf5b4663cd517fb6d69b5373dd0e6520e87cf8e > src/tests/authorization_tests.cpp 41ecac29a53f6ad9553cbf0a1121e1f3cff50df8 > > > Diff: https://reviews.apache.org/r/68103/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
