----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68114/#review206736 -----------------------------------------------------------
Fix it, then Ship it! LGTM. Two things: * let's commit this before e.g., https://reviews.apache.org/r/68091/ * please also change this in `3rdparty/libprocess/3rdparty/Makefile.am` in a separate patch. 3rdparty/Makefile.am Lines 432-433 (patched) <https://reviews.apache.org/r/68114/#comment289829> Let's mention an example of a compiler where this triggered a diagnostic. That way we have some chance to find out whether this is still an issue in the future. 3rdparty/Makefile.am Lines 440 (patched) <https://reviews.apache.org/r/68114/#comment289828> Alternatively we could just disable this diagnostic with `-Wno-array-bounds` since neither us nor our users are interested in fixing it and it just adds noise. I do not have a very strong preference, up to you. - Benjamin Bannier On July 31, 2018, 2:05 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68114/ > ----------------------------------------------------------- > > (Updated July 31, 2018, 2:05 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-8395 > https://issues.apache.org/jira/browse/MESOS-8395 > > > Repository: mesos > > > Description > ------- > > When compiling gRPC with Clang, there are some array-out-of-bound > warnings due to the use of GLIBC's `__strcmp_cg` macro in the c-ares > library. With `-Werror` on, these warnings would stop gRPC from > compiling. This patch ignores such errors. > > > Diffs > ----- > > 3rdparty/Makefile.am 26e5d55561731ff03639df31562bb835d9687339 > > > Diff: https://reviews.apache.org/r/68114/diff/1/ > > > Testing > ------- > > `sudo make check` with clang on ubuntu 16.04, which triggers the warnings. > > > Thanks, > > Chun-Hung Hsiao > >
