----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68152/#review206767 -----------------------------------------------------------
Ship it! I'd be a bit verbose on the commit message: ``` Previously, we are missing a `-w` option for one iptable command, which will cause the iptables command to fail if any application is holding the xtables lock. By using `-w`, the iptables will wait for the xtables lock to be released, instead of failing. ``` - Jie Yu On Aug. 1, 2018, 10:23 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68152/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2018, 10:23 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-9125 > https://issues.apache.org/jira/browse/MESOS-9125 > > > Repository: mesos > > > Description > ------- > > Added missing iptables argument in CNI port mapper. > > > Diffs > ----- > > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > c40b57f78193520f9f0b901201b5c4c855cde8b3 > > > Diff: https://reviews.apache.org/r/68152/diff/1/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
