----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206788 -----------------------------------------------------------
src/master/master.hpp Lines 2981-2983 (original) <https://reviews.apache.org/r/68141/#comment289870> I think these qualify to stay in ".hpp". src/master/master.hpp Lines 2985-2987 (original), 2449-2451 (patched) <https://reviews.apache.org/r/68141/#comment289869> Can you please move all `Framework::*` definitions from "master.cpp" to "framework.cpp"? - Alexander Rukletsov On Aug. 2, 2018, 10:26 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68141/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2018, 10:26 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-2633 > https://issues.apache.org/jira/browse/MESOS-2633 > > > Repository: mesos > > > Description > ------- > > This change aims to reduce compile time and cognitive > load when browsing the "master.hpp" header. > > > Diffs > ----- > > src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e > src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66 > src/master/framework.cpp PRE-CREATION > src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 > > > Diff: https://reviews.apache.org/r/68141/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benno Evers > >
