----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68166/#review206796 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rukletsov On Aug. 2, 2018, 12:17 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68166/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2018, 12:17 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > This commit contains some fixups to the movement of the Framework > implementation code to a separate file in the previous commit. > > * Changed Framework::send() to use an out-of-class definition. > * Moved back trivial functions back to the header file. > * Moved private constructor to the top of the file in `framework.cpp`. > > > Diffs > ----- > > src/master/framework.cpp PRE-CREATION > src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 > > > Diff: https://reviews.apache.org/r/68166/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
