----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68176/ -----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. Repository: mesos Description ------- The gRPC library was by default built by CMake with the "Debug" configuration on Windows, even if Mesos is built with the "Release" configuration. As a result, gRPC would try to link to the "Debug" protobuf library and end up with a failure. This patch fixes this problem by explicitly specifying the configuration in gRPC's build command. Diffs ----- 3rdparty/CMakeLists.txt 8300088aaec5afd5ea92268757235d8561cda916 Diff: https://reviews.apache.org/r/68176/diff/1/ Testing ------- Built and tested using VS on Windows Built and tested using VS on Windows with `--config Release` Built and tested using Ninja on Linux Built and tested using Makefile on Linux Thanks, Chun-Hung Hsiao
