----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/#review206875 -----------------------------------------------------------
3rdparty/libprocess/include/process/statistics.hpp Lines 60 (patched) <https://reviews.apache.org/r/68224/#comment289972> Aren't you missing a `::value` after `std::is_same<>`, assuming you're going for SFINAE here? Also, what's the reason for being so strict? Shouldn't `std::is_convertible<>` be enough? 3rdparty/libprocess/include/process/statistics.hpp Lines 68 (patched) <https://reviews.apache.org/r/68224/#comment289973> I wonder if we should just reserve `std::distance(first, last)` if we don't get `InputIterator`s. Intuitively it feels like even in the worst case, doing an additional iteration should be faster than the additional memory allocations. 3rdparty/libprocess/src/tests/statistics_tests.cpp Lines 28 (patched) <https://reviews.apache.org/r/68224/#comment289974> This is adding more characters than just writing out the namespace in the test ;) - Benno Evers On Aug. 6, 2018, 10:30 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68224/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2018, 10:30 a.m.) > > > Review request for mesos, Benno Evers and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/statistics.hpp > e9f1fc23bf83f92a2e7de94dba0df48272cc3394 > 3rdparty/libprocess/src/tests/statistics_tests.cpp > a2a780bf9de018c823b68aa48977fd9fd1b8a064 > > > Diff: https://reviews.apache.org/r/68224/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > >
