----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review206877 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_benchmarks.cpp Lines 496 (patched) <https://reviews.apache.org/r/68131/#comment289976> Is it possible to store the last parameter directly as `process::Milliseconds`? src/tests/master_benchmarks.cpp Lines 628 (patched) <https://reviews.apache.org/r/68131/#comment289977> The `async()` seems unnecessary here, we can just call the function directly. src/tests/master_benchmarks.cpp Lines 634 (patched) <https://reviews.apache.org/r/68131/#comment289978> Maybe we should add one run here where we query only `stateEndpoint` without hitting `indicatorEndpoint` at the same time? - Benno Evers On Aug. 6, 2018, 10:30 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68131/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2018, 10:30 a.m.) > > > Review request for mesos, Benno Evers and Benjamin Mahler. > > > Bugs: MESOS-8975 > https://issues.apache.org/jira/browse/MESOS-8975 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/master_benchmarks.cpp b6d6dc7c1752491e2da854018966374b624d6682 > > > Diff: https://reviews.apache.org/r/68131/diff/2/ > > > Testing > ------- > > See https://reviews.apache.org/r/68132/ > > > Thanks, > > Alexander Rukletsov > >
