Re: Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator.

[Benjamin Mahler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68123/#review206915
-----------------------------------------------------------




src/master/allocator/mesos/hierarchical.cpp
Lines 807-815 (original), 807-815 (patched)
<https://reviews.apache.org/r/68123/#comment290051>

    Let's use an option instead of a sentinel value:
    
    ```
    Option<string> role;
    ...
    
    if (role.isNone()) { set }
    else { CHECK_EQ(role, ...role()); }
    
    CHECK_NOTNONE(role);
    ```
    
    Did I forget to make this suggestion on a similar recent patch?


- Benjamin Mahler


On July 31, 2018, 5:17 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68123/
> -----------------------------------------------------------
> 
> (Updated July 31, 2018, 5:17 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 35992474eacb8b14ae57e1dc23307e1542f63cb5 
> 
> 
> Diff: https://reviews.apache.org/r/68123/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>