----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/#review206920 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/cni_isolator_tests.cpp Line 1946 (original), 1974 (patched) <https://reviews.apache.org/r/68239/#comment290068> Nit: Move the declaration close to the use. - Chun-Hung Hsiao On Aug. 6, 2018, 11:42 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68239/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2018, 11:42 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Repository: mesos > > > Description > ------- > > This patch updated the port mapper CNI test to launch multiple > containers concurrently. This would allow us to catch the scenarios > where multiple iptables commands are executed concurrently. > > This test fails if the fix for MESOS-9125 is not included. > > > Diffs > ----- > > src/common/values.hpp 39487b955fc1a3c963f69de66ba0da869dd3ab2e > src/tests/containerizer/cni_isolator_tests.cpp > 90d2d4103c8136d2dd883318acc135f7efca80d8 > > > Diff: https://reviews.apache.org/r/68239/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
