----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207077 -----------------------------------------------------------
PASS: Mesos patch 68054 was successfully built and tested. Reviews applied: `['68052', '68053', '68054']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2126/mesos-review-68054 - Mesos Reviewbot Windows On Aug. 10, 2018, 2:39 a.m., Sergey Urbanovich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68054/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2018, 2:39 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-5647 > https://issues.apache.org/jira/browse/MESOS-5647 > > > Repository: mesos > > > Description > ------- > > On receiving a request for getting `usage` for a given container > the `network/cni` isolator uses getifaddrs(3) glibc function. The > function returns basic networking metrics for each networking > interface in the container networking namespace. It should work > right out of the box on all modern Linux-based systems. > > To get more networking metrics please use Netlink Protocol Library. > However, you will have to open NETLINK sockets in each networking > namespace and manage them from the `network/cni` isolator. > > JIRA: https://issues.apache.org/jira/browse/MESOS-5647 > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 31ec4ddb1049b7259b0784e5e40b002e29f6a8da > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > f46c962d8f044092aaa113fafc536c6b25bab45c > src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe > src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 > src/tests/containerizer/cni_isolator_tests.cpp > cae2c1950c6e5218f7fc7cebd93f5b4ed687fb5a > > > Diff: https://reviews.apache.org/r/68054/diff/4/ > > > Testing > ------- > > bin/mesos-tests.sh --verbose > --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" > --gtest_break_on_failure --gtest_repeat=100 > > > Thanks, > > Sergey Urbanovich > >
