----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/#review207168 -----------------------------------------------------------
src/slave/slave.cpp Line 1366 (original), 1383 (patched) <https://reviews.apache.org/r/68304/#comment290461> Should we multiply `maxBackoff` by `2` here? I don't see it being increased anywhere else. src/slave/slave.cpp Lines 1386-1387 (patched) <https://reviews.apache.org/r/68304/#comment290462> Nit: I would move this comment to before the if statement, and the note that is currently above to within it. - Gastón Kleiman On Aug. 10, 2018, 4:41 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68304/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2018, 4:41 p.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Bugs: MESOS-9147 > https://issues.apache.org/jira/browse/MESOS-9147 > > > Repository: mesos > > > Description > ------- > > This patch fixed the backoff time calculation > overflow bug described in MESOS-9147. > > This patch also combines the authentication timeout and > authentication retry backoff interval into a single > wait time interval. > > > Diffs > ----- > > src/slave/slave.hpp 802d4eb9e9eba2f1175dd85e56dcc80a61e32f74 > src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c > src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9 > > > Diff: https://reviews.apache.org/r/68304/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >