----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68219/#review207185 -----------------------------------------------------------
Ship it! src/slave/containerizer/mesos/isolators/volume/secret.cpp Lines 287 (patched) <https://reviews.apache.org/r/68219/#comment290479> Why not the same order as previous patches? I guess it does not hurt - Gilbert Song On Aug. 7, 2018, 7:22 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68219/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2018, 7:22 a.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. > > > Bugs: MESOS-8814 > https://issues.apache.org/jira/browse/MESOS-8814 > > > Repository: mesos > > > Description > ------- > > Updated `volume/secret` isolator to honor volume mode. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/volume/secret.cpp > 663aafc7173667f8f78b26bdc824a3ab2e04ed25 > > > Diff: https://reviews.apache.org/r/68219/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
