----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68305/#review207333 -----------------------------------------------------------
src/master/flags.cpp Lines 237-242 (patched) <https://reviews.apache.org/r/68305/#comment290691> We don't make much use of the 'v0' name for the unversioned APIs in the documentation and flags. I might say something like "The timeout within which non-HTTP authentication must complete. This applies to agents and SchedulerDriver-based frameworks." It might be OK to just call this flag 'authentication_timeout', since the doc string specifies the cases to which it's relevant? - Greg Mann On Aug. 13, 2018, 10:22 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68305/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2018, 10:22 p.m.) > > > Review request for mesos, Alexander Rojas, Gastón Kleiman, Meng Zhu, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-9145 > https://issues.apache.org/jira/browse/MESOS-9145 > > > Repository: mesos > > > Description > ------- > > There is not a lot of value in the master timing out a client's > authentication, other than releasing a small amount of resources. > We currently have a burned in 5 second timeout, which is largely > sufficient since most authenticators are implemented to use an > actor per session and avoid any head-of-line blocking. > > Ideally, the master would know how long the client's timeout and > the master can use that for its own timeout. The current max backoff > for schedulers and agents is 1 minute, so this patch bumps the > master's timeout to be closer to that (15 seconds). We don't bump it > further because the vast majority of the timeout time is spent in > the initial trip through the master's queue, which occurs before > the master sets up its timeout. > > This also adds a flag, both to allow users to tune this, as well > as to allow us to control timing in tests. > > > Diffs > ----- > > docs/authentication.md ab3791b7d0c52826213f735b4acf5627b2925330 > docs/configuration/master.md 2090090894211ee7f5b7ffce58256f1b678b375a > src/master/constants.hpp f3b257a8a4c492593c701af442a0acc2b3c01762 > src/master/flags.hpp 3929c297b45e1203e5b00454e88f86988a8b1058 > src/master/flags.cpp 8fede0d2cf2254f34134329885f47c3c78dc5846 > src/master/master.cpp 400a83e35451a3ee0ea42b5ca729357bf6c744e8 > > > Diff: https://reviews.apache.org/r/68305/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
