----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/#review207435 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Aug. 16, 2018, 9:03 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68346/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2018, 9:03 p.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Bugs: MESOS-9147 > https://issues.apache.org/jira/browse/MESOS-9147 > > > Repository: mesos > > > Description > ------- > > This patch fixed the backoff time calculation > overflow bug described in MESOS-9147. > > The old approach times out an authentication request after > `flags.authentication_timeout` and then retries after some > backoff time. This is not optimal because, if the scheduler > is going to backoff some time before retry, we might as well > wait that long for the previous authentication request > (instead of timeout early). > > This patch combines the authentication timeout and > authentication retry backoff interval into a single > wait time interval. Now scheduler will timeout the previous > authentication request after the wait time interval and > then immediately retry. > > > Diffs > ----- > > src/sched/constants.hpp 9edb25b38ba8e7e1dbbb4ce4c957bb6bd9f4af81 > src/sched/flags.hpp 2492665d44c424ff9f4f73c796520ebc51abbdff > src/sched/sched.cpp 4de76225c73c9c17904512f5a72303d93ec915a7 > > > Diff: https://reviews.apache.org/r/68346/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
