----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68361/#review207457 -----------------------------------------------------------
Ship it! Ship It! - Chun-Hung Hsiao On Aug. 15, 2018, 1:47 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68361/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2018, 1:47 p.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Bugs: MESOS-9156 > https://issues.apache.org/jira/browse/MESOS-9156 > > > Repository: mesos > > > Description > ------- > > `StorageLocalResourceProviderProcess::fatal` causes termination of the > process' driver process via destruction of the driver process' > wrapper. The wrapper correctly makes sure to `wait` for the process to > finish. Due to the `wait` we must never call `fatal` on the driver > process actor itself as otherwise the `wait` would deadlock. > > This patch adds missing `defer`s so `fatal` is executed on the SLRP > actor instead of an arbitrary actor, like e.g., the driver process > actor. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > 22c184f45ea43335c3e1e4598f7409a4f05fb38e > > > Diff: https://reviews.apache.org/r/68361/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
