----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/#review207503 -----------------------------------------------------------
Patch looks great! Reviews applied: [68052, 68053, 68054, 68355] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 17, 2018, 3:37 a.m., Sergey Urbanovich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68355/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 3:37 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-5647 > https://issues.apache.org/jira/browse/MESOS-5647 > > > Repository: mesos > > > Description > ------- > > This is a veth CNI plugin that is written in bash. It creates a veth > virtual network pair, one end of the pair will be moved to container > network namespace. > > The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for > documentation and examples [rfc5737]. The plugin can allocate up to > 128 veth pairs. > > > Diffs > ----- > > src/tests/containerizer/cni_isolator_tests.cpp > 63b109bdbc23733aa3d4cdce1de5385ad9933be8 > src/tests/environment.cpp 8c6ec5854268d3c497b9671a95768d6a174673c6 > > > Diff: https://reviews.apache.org/r/68355/diff/6/ > > > Testing > ------- > > bin/mesos-tests.sh --verbose > --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" > --gtest_break_on_failure --gtest_repeat=100 > > > Thanks, > > Sergey Urbanovich > >